On Wed, Oct 14, 2015 at 10:20 AM, Olaf Hering <olaf at aepfle.de> wrote: > On Sun, Oct 11, Laurent Vivier wrote: > >> On PowerMac G5 (and I think on all OpenFirmware platforms), nvbios_pcirTp() >> returns NULL. But in fact the OpenFirmware has given us the size >> we can store in image->size. > >> CC: imirkin at alum.mit.edu >> Signed-off-by: Laurent Vivier <laurent at vivier.eu> > > Tested-by: Olaf Hering <olaf at aepfle.de> > > Broken since a while already... > https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-March/126737.html
FTR, looks like my version is upstream now: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=25d295882a1adfcdaaad85369289677b87c7c8f0 I agree that my of_size thing was a bit of a hack, if you want to redo it by removing of_size/of_read from shadowof.c and copying it in at init time (also a hack, IMHO), I certainly wouldn't object. As before, it's Ben's call though. -ilia
