Hello, On 2015-11-13 03:29, Krzysztof Kozlowski wrote: > On 10.11.2015 22:23, Marek Szyprowski wrote: >> This patch adds device node for Rotator device to Exynos 4210 and 4x12 >> device tree files. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com> >> --- >> arch/arm/boot/dts/exynos4.dtsi | 10 +++++++++- >> arch/arm/boot/dts/exynos4210.dtsi | 8 ++++++++ >> arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++ >> 3 files changed, 21 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >> index 2f31f773b096..3fa575ad7693 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi >> @@ -718,6 +718,15 @@ >> iommus = <&sysmmu_jpeg>; >> }; >> >> + rotator: rotator at 12810000 { >> + compatible = "samsung,exynos4210-rotator"; >> + reg = <0x12810000 0x1000>; > One more question after looking at second patch. You are mapping size of > 0x1000 instead of 0x64. Any particular reason? (it does not really > matter... just wondering)
Nope, it might be just a copy/paste issue I've missed. Do you want to unify it to 0x64 or 0x1000? Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland