On 03/11/2015 02:51 AM, Jani Nikula wrote: > They are not to be modified. > > Generated using the semantic patch: > > @@ > @@ > ( > const struct drm_crtc_helper_funcs * > | > - struct drm_crtc_helper_funcs * > + const struct drm_crtc_helper_funcs * > ) > > @@ > @@ > ( > const struct drm_encoder_helper_funcs * > | > - struct drm_encoder_helper_funcs * > + const struct drm_encoder_helper_funcs * > ) > > @@ > @@ > ( > const struct drm_connector_helper_funcs * > | > - struct drm_connector_helper_funcs * > + const struct drm_connector_helper_funcs * > ) > > @@ > @@ > ( > const struct drm_plane_helper_funcs * > | > - struct drm_plane_helper_funcs * > + const struct drm_plane_helper_funcs * > ) > > Signed-off-by: Jani Nikula <jani.nikula at intel.com> > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c > b/drivers/gpu/drm/mgag200/mgag200_mode.c > index 9872ba9abf1a..6e84df9369a6 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_mode.c > +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c > @@ -1222,7 +1222,7 @@ static void mga_crtc_commit(struct drm_crtc *crtc) > { > struct drm_device *dev = crtc->dev; > struct mga_device *mdev = dev->dev_private; > - struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private; > + const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
Presumably cases like this one could be 'const struct drm_crtc_helper_funcs *const' but meh. This patch is Reviewed-by: Ian Romanick <ian.d.romanick at intel.com> ...who hasn't had a patch in the Matrox driver in almost a decade. > u8 tmp; > > if (mdev->type == G200_WB) >