Hi, On 03/04/2015 12:06 AM, Stephane Viau wrote: > DSI and WB interfaces need a more complex pipeline configuration > than the current mdp5_ctl_set_intf(). > > For example, memory output connections need to be selected for > WB. Interface mode (Video vs. Command modes) also need to be > configured for DSI. > > This change takes care of configuring the whole pipeline as far > as operation mode goes. DSI and WB interfaces will be added > later. > > Signed-off-by: Stephane Viau <sviau at codeaurora.org> > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h | 2 + > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 39 ++----------- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.c | 91 > +++++++++++++++++++++++++---- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.h | 3 +- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c | 29 +++++---- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 16 ++++- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 48 ++++++++++++--- > 7 files changed, 157 insertions(+), 71 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > index dba4d52..be587b8 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h > @@ -31,6 +31,8 @@ extern const struct mdp5_cfg_hw *mdp5_cfg; > > typedef DECLARE_BITMAP(mdp5_smp_state_t, MAX_SMP_BLOCKS); > > +#define MDP5_INTF_IS_VIRTUAL_DISPLAY(intf_type) ((intf_type) >= > INTF_VIRTUAL) > +
Minor comment and probably matter of taste. Having the above as mdp5_intf_is_virtual() would seem better in the code. <snip> Thanks, Archit
