Ever since framebuffers are reference counted we have a special lock
for the global fb list. Make sure users of that list do hold that
lock when using the new iterators.

Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 include/drm/drm_crtc.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 499562274353..10547be5684a 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -1606,6 +1606,10 @@ assert_drm_connector_list_read_locked(struct 
drm_mode_config *mode_config)
        list_for_each_entry(encoder, &(dev)->mode_config.encoder_list, head)

 #define drm_for_each_fb(fb, dev) \
-       list_for_each_entry(fb, &(dev)->mode_config.fb_list, head)
+       for (WARN_ON(!mutex_is_locked(&(dev)->mode_config.fb_lock)),            
\
+            fb = list_first_entry(&(dev)->mode_config.fb_list, \
+                                         struct drm_framebuffer, head);        
\
+            &fb->head != (&(dev)->mode_config.fb_list);                        
\
+            fb = list_next_entry(fb, head))

 #endif /* __DRM_CRTC_H__ */
-- 
2.1.4

Reply via email to