Hello The etnaviv authors,
The patch a8c21a5451d8: "drm/etnaviv: add initial etnaviv DRM driver"
from Dec 3, 2015, leads to the following static checker warning:
drivers/gpu/drm/etnaviv/etnaviv_gpu.c:254 etnaviv_hw_identify()
warn: masked condition '(((chipIdentity) << 24) & 4278190080) == 1' is
always false.
drivers/gpu/drm/etnaviv/etnaviv_gpu.c
247 static void etnaviv_hw_identify(struct etnaviv_gpu *gpu)
248 {
249 u32 chipIdentity;
250
251 chipIdentity = gpu_read(gpu, VIVS_HI_CHIP_IDENTITY);
252
253 /* Special case for older graphic cores. */
254 if (VIVS_HI_CHIP_IDENTITY_FAMILY(chipIdentity) == 0x01) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not possibly true.
255 gpu->identity.model = 0x500; /* gc500 */
256 gpu->identity.revision =
VIVS_HI_CHIP_IDENTITY_REVISION(chipIdentity);
257 } else {
258
regards,
dan carpenter
