On 30/09/14 14:52, Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 01:49:20PM +0200, Daniel Vetter wrote: >> On Tue, Sep 30, 2014 at 02:42:01PM +0300, Tomi Valkeinen wrote: >>> On 06/08/14 11:40, Daniel Vetter wrote: >>>> This allows us to ditch the driver-private lastclose logic. >>>> >>>> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com> >>>> Cc: Rob Clark <robdclark at gmail.com> >>>> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> >>>> >>>> -- >>>> >>>> Untested and atm only applies on top of drm-intel-nightly. >>> >>> I could give this a try if you point me to a git tree with the patch. >> >> I should apply on top of drm-next nowadays, prerequisites that went in >> through drm-intel are all merged now. I guess you'll take care of this one >> now?
It didn't compile, but it was trivial to fix. And yes, I can pick it to my omapdrm patches, which I guess will be delayed until 3.19. > btw if this works you can drop the entire if (rotation_property) hunk from > lastclose, since the fbdev helper now takes care of this itself: > > commit 3a5f87c286515c54ff5c52c3e64d0c522b7570c0 > Author: Thomas Wood <thomas.wood at intel.com> > Date: Wed Aug 20 14:45:00 2014 +0100 > > drm: fix plane rotation when restoring fbdev configuration I updated the patch, with the compile fix and removal of the lastclose stuff. Seems to work fine with a quick test: I exit X (after fiddling with xrandr rotation in there), and I see the rotation property restored to the default value. Tomi
