On Tue, Sep 16, 2014 at 3:03 PM, Kyle McMartin <kyle at redhat.com> wrote: > They don't appear to be used anywhere... elsewhere uses R*_PTE_*. > > master at linux:U:.% git grep PTE_ -- drivers/gpu/drm/radeon | grep -v _PTE_ > master at linux:U:.% (kyle at redacted:~/linux) > > ./arch/arm64/include/asm/pgtable.h:27:0: note: this is the location of the > previous definition > #define PTE_VALID (_AT(pteval_t, 1) << 0) > ^ > In file included from drivers/gpu/drm/radeon/r600_cs.c:31:0: > drivers/gpu/drm/radeon/r600d.h:48:0: warning: "PTE_VALID" redefined [enabled > by default] > #define PTE_VALID (1 << 0) > ^ > In file included from ./arch/arm64/include/asm/io.h:29:0, > from include/linux/clocksource.h:19, > from include/clocksource/arm_arch_timer.h:19, > from ./arch/arm64/include/asm/arch_timer.h:27, > from ./arch/arm64/include/asm/timex.h:19, > from include/linux/timex.h:65, > <snip> > from include/drm/drmP.h:51, > from drivers/gpu/drm/radeon/r600_cs.c:29: > ./arch/arm64/include/asm/pgtable.h:27:0: note: this is the location of the > previous definition > #define PTE_VALID (_AT(pteval_t, 1) << 0) > ^ > > Signed-off-by: Kyle McMartin <kyle at redhat.com>
Applied. thanks! Alex > > --- a/drivers/gpu/drm/radeon/r600d.h > +++ b/drivers/gpu/drm/radeon/r600d.h > @@ -44,13 +44,6 @@ > #define R6XX_MAX_PIPES 8 > #define R6XX_MAX_PIPES_MASK 0xff > > -/* PTE flags */ > -#define PTE_VALID (1 << 0) > -#define PTE_SYSTEM (1 << 1) > -#define PTE_SNOOPED (1 << 2) > -#define PTE_READABLE (1 << 5) > -#define PTE_WRITEABLE (1 << 6) > - > /* tiling bits */ > #define ARRAY_LINEAR_GENERAL 0x00000000 > #define ARRAY_LINEAR_ALIGNED 0x00000001 > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
