On Fri, Oct 24, 2014 at 2:58 PM, Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com> wrote: > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -279,4 +279,8 @@ int > drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe > *frame, > const struct drm_display_mode > *mode); > > +struct edid *drm_do_get_edid(struct drm_connector *connector, > + int (*get_edid_block)(void *, u8 *buf, unsigned int, size_t),
It doesn't hurt to add parameter names for all parameters, as hints for implementors. > + void *data); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds