On 11/25/2014 12:24 PM, Dan Carpenter wrote:
> The call to kernel_queue_uninit(NULL) will trigger a BUG(), and also the
> error code is incorrect.
>
> Fixes: 45102048f77e ('amdkfd: Add process queue manager module')
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
Patch is:
Reviewed-by: Oded Gabbay <oded.gabbay at amd.com>
And applied to my 3.19-next-wip tree.
Thanks!
Oded
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> index c7859fc..7ce7a25 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> @@ -208,7 +208,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
> case KFD_QUEUE_TYPE_DIQ:
> kq = kernel_queue_init(dev, KFD_QUEUE_TYPE_DIQ);
> if (kq == NULL) {
> - kernel_queue_uninit(kq);
> + retval = -ENOMEM;
> goto err_create_queue;
> }
> kq->queue->properties.queue_id = *qid;
>
