On Nov 19, 2014 4:41 PM, "SF Markus Elfring" <elfring at users.sourceforge.net> wrote: > > From: Markus Elfring <elfring at users.sourceforge.net> > Date: Wed, 19 Nov 2014 16:33:17 +0100 > > The release_firmware() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring at users.sourceforge.net> > --- > drivers/gpu/drm/drm_edid_load.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c > index 0a235fe..732cb6f 100644 > --- a/drivers/gpu/drm/drm_edid_load.c > +++ b/drivers/gpu/drm/drm_edid_load.c > @@ -254,8 +254,7 @@ static void *edid_load(struct drm_connector *connector, const char *name, > name, connector_name); > > out: > - if (fw) > - release_firmware(fw); > + release_firmware(fw); > return edid; > } >
Reviewed-by: Thierry Reding <thierry.reding at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20141120/a928aba2/attachment.html>
