On 06/17/2014 09:17 AM, Guido Mart?nez wrote:
> Use module_init instead of late_initcall, as is the norm for modular
> drivers.
>
> module_init was used until 6e8de0bd6a51fdeebd5d975c4fcc426f730b339b
> ("drm/tilcdc: add encoder slave (v2)") changed it to a late_initcall,
> but it does not explain why. Tests show it's working properly with
> module_init.
>
If I recall, the late_initcall stuff was done to try and make sure the
tda998x/i2c subsystem came up before tilcdc. However it didn't always
work so we added commit: 39de6194131c155901f96686a063212656d80c2e to try
and ensure the ordering. This might be why changing back to module_init
is fine (and I agree with your assessment from my testing).
> Signed-off-by: Guido Mart?nez <guido at vanguardiasur.com.ar>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 2c860c4..6be623b 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -629,7 +629,7 @@ static void __exit tilcdc_drm_fini(void)
> tilcdc_tfp410_fini();
> }
>
> -late_initcall(tilcdc_drm_init);
> +module_init(tilcdc_drm_init);
> module_exit(tilcdc_drm_fini);
>
> MODULE_AUTHOR("Rob Clark <robdclark at gmail.com");
>
