On Sat, 2014-12-27 at 21:22 +0100, Rafael J. Wysocki wrote:
[]
> +++ linux-pm/include/acpi/acpi_bus.h
> @@ -589,7 +589,8 @@ static inline u32 acpi_target_system_sta
>  
>  static inline bool acpi_device_power_manageable(struct acpi_device *adev)
>  {
> -     return adev->flags.power_manageable;
> +     return adev->flags.power_manageable
> +             && (adev->status.present || adev->status.functional);

Most code in the kernel has these logical
continuations at the end of the previous line.

> +++ linux-pm/drivers/acpi/device_pm.c
[]
> @@ -361,7 +362,7 @@ bool acpi_bus_power_manageable(acpi_hand
>       int result;
>  
>       result = acpi_bus_get_device(handle, &device);
> -     return result ? false : device->flags.power_manageable;
> +     return result ? false : acpi_device_power_manageable(device);

This might read better as:

        if (acpi_bus_get_device(handle, &device))
                return false;

        return acpi_device_power_manageable(device);


Reply via email to