On 12/17/2014 06:02 AM, Philipp Zabel wrote:
>
> The interlaced parameter to ipu_dc_init_sync is of type bool, so the
> ()?true:false is superfluous.

fixed.

>
> [...]
>> @@ -433,10 +437,11 @@ static void ipu_di_config_clock(struct ipu_di *di,
>>                      unsigned long in_rate;
>>                      unsigned div;
>>  
>> -                    clk_set_rate(clk, sig->pixelclock);
>> +                    clk_set_rate(clk, sig->mode.pixelclock);
>>  
>>                      in_rate = clk_get_rate(clk);
>> -                    div = (in_rate + sig->pixelclock / 2) / sig->pixelclock;
>> +                    div = (in_rate + sig->mode.pixelclock / 2) /
>> +                            sig->mode.pixelclock;
> Let's use this opportunity to switch to DIV_ROUND_CLOSEST here ...

I'll add a separate patch for that.

Steve

Reply via email to