Hi lars: thks for your review, I will move it to hdmi audio driver, give the codec_name & codec_dai_name an const string.
Best Regards. Yang KuanKuan | Software Engineer | 15060416783 | ykk at rock-chips.com From: Lars-Peter Clausen Date: 2014-12-15 17:02 To: Yakir Yang CC: Heiko Stuebner; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Russell King; Philipp Zabel; Zubair.Kakakhel; Fabio Estevam; Shawn Guo; dri-devel; Daniel Kurtz; Sonny Rao; Dylan Reid; Xu Jianqun; St��phane Marchesin; Brian Austin; Bard Liao; Max Filippov; Oder Chiou; devicetree; linux-kernel; linux-arm-kernel; linux-rockchip; alsa-devel; Arnd Bergmann; David Airlie; Sean Cross; Grant Likely; Greg Kroah-Hartman; Ben Zhang; Liam Girdwood; Jaroslav Kysela; Mark Brown; Takashi Iwai; Jyri Sarha Subject: Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio On 12/15/2014 03:55 AM, Yakir Yang wrote: [...] > +- codec-name: the dw-hdmi codec's device name > +- codec-dai-name: the dw-hdmi codec's dai name Please you phandles for this, the names are Linux driver and framework specific details. That should not leak into the DT bindings. [..] -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20141215/dda0ad23/attachment-0001.html>
