2010/9/18 Marcin Slusarz <marcin.slus...@gmail.com>:
> On Fri, Sep 17, 2010 at 06:53:26PM -0400, Andy Walls wrote:
>> On my system, every 10 seconds drm_edid_block_valid() gets called 4
>> times by radeon_dvi_detect(). This results in 4 instances of a
>> multi-line hex dump of the same EDID (non-)data being logged every 10
>> seconds.
>>
>> Silence the hex dump from drm_edid_block_valid() unless a drm_debug
>> module parameter flag is set.
>>
>> Signed-of-by: Andy Walls <awa...@md.metrocast.net>
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index dce5c4a..33a748c 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -173,9 +173,12 @@ drm_edid_block_valid(u8 *raw_edid)
>>
>> bad:
>> if (raw_edid) {
>> - DRM_ERROR("Raw EDID:\n");
>> - print_hex_dump_bytes(KERN_ERR, DUMP_PREFIX_NONE, raw_edid,
>> EDID_LENGTH);
>> - printk("\n");
>> + DRM_DEBUG("Raw EDID:\n");
>> + if (drm_debug & DRM_UT_CORE) {
>> + print_hex_dump_bytes(KERN_ERR, DUMP_PREFIX_NONE,
>> + raw_edid, EDID_LENGTH);
>> + printk("\n");
>> + }
>> }
>> return 0;
>> }
>>
>
> Why not print it only once on original error level?
> Something like:
> static bool printed = false;
> if (!printed) {
> ...
> printed = true;
> }
>
> It has the same effect for you (no spamming by default) and it's still
> provide some information.
Should be per-monitor or per-output I think.
--
Rafał
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
