-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Timo Sirainen wrote the following on 20.11.2013 20:08: > On 20.11.2013, at 14.40, Timo Sirainen <t...@iki.fi> wrote: > >> On 20.11.2013, at 5.33, Tamsy <dovecot-l...@mohtex.net> wrote: >> >>> When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" >>> Pigeonhole is throwing the following message and stops: >>> >>> Test case: ./tests/test-header.svtest: >>> >>> 1: Test 'Basic functionality' SUCCEEDED >>> 2: Test 'Matching empty key' SUCCEEDED >>> 3: Test 'Ignoring whitespace' FAILED: header test does not strip >>> leading whitespace >>> 4: Test 'Absent or empty header' SUCCEEDED >>> 5: Test 'Invalid header name' SUCCEEDED >>> 6: Test 'Folded header’ SUCCEEDED >> Interestingly caused by the improved caching code. Fixed by http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2 > And http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56 > > These are very old bugs. Wonder if they’ve caused other trouble earlier. >
Hi Timo, After applying your patches to Dovecot 2.2.8: 1. http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2 2. http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 3. http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56 I can confirm that "make check" using latest dovecot-2-2-pigeonhole-b7434a02fc51 from the Mercurial repository is finishing without error now, all tests are succeeding. In particular "Test case: ./tests/test-header.svtest": 1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' SUCCEEDED 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED PASS: 6 tests succeeded. Thank you, Tamsy -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQEcBAEBAgAGBQJSjLzMAAoJEKYXVM1dyOfZzvwH/1Xl5ysdOFQel5jWMeCDtuZP a/nli5L0mZe2l16MVdUJ8lDn7tpQv13WkZV81vYTIayu/b+MTGa1OZVoQakgWUUx dF26Jc0E5/pVOM0jlJgagGjwhFjjAUGkOeKEfIi6ScGekTuvunlBfkJ+rbouAise HCRHnPgvIv+o+S8hDNTOyKz2S8/2cR/Yip8j2k6UYn9DUCR1Phs7ypugkcXhBIHG ee4vHyY0tFCprps9tN12xr+qOn7R/wTHTqw9JZZNyXVrxt3ZLOH7IApeaWeMNFDz FmwKjrDiXHK0HVJVVfjvvSZqDX5+BMFe4kDiKVqEdewex1b+tVXTCD5wSlU3pTk= =srRX -----END PGP SIGNATURE-----
0x5DC8E7D9.asc
Description: application/pgp-keys
