Sorry for the flurry of messages! ...

On 2 Aug 2007, at 17:06, Mike Brudenell wrote:

However there doesn't seem to be anything in the existing 1.0.3 source or the three patches that provides this function.

Is there something missing from the patches at
http://hg.dovecot.org/dovecot/diff/078d9dde99c8/src/plugins/ quota/quota-fs.c
?

I've just tried #including the rquota_cdr.c file produced by running rpcgen on the rquota.x file (as in the code I sent out a few days ago).

That compiled and runs OK, and successfully returns a storage when queries with the GETQUOTAROOT command:

    a02 getquotaroot inbox
    * QUOTAROOT "inbox" "pmb1"
    * QUOTA "pmb1" (STORAGE 72970240 104857600)
    a02 OK Getquotaroot completed.

*BUT* the units returned are not correct: they appear to be coming back as bytes when the RFC says that they should be in units of 1024 octets:

    http://rfc.net/rfc2087.html#s3.

The fix is, I think, trivial: just update a comment and divide by 1024 in a couple of places. See attached patch, to be used after the other three.

The mystery of the missing xdr_getquota_args() still needs sorting properly though.

Cheers,
Mike B-)

--
The Computing Service, University of York, Heslington, York Yo10 5DD, UK
Tel:+44-1904-433811  FAX:+44-1904-433740

* Unsolicited commercial e-mail is NOT welcome at this e-mail address. *

Attachment: quota-fs.c.patch2
Description: Binary data


Reply via email to