On 15.4.2007, at 7.36, Frank Cusack wrote:

In passdb-pam.c, I found some bits about const with some PAM data types.
Rather than check for each vendor of PAM, better to check for actual
const usage ... some vendors have changed const-ness between releases.
Also, actually testing constness is great for supporting new
implementations that may come out.

Here is the autoconf test I use in pam_otp_auth:

--8<--
# Check PAM headers for brokenness
otp_CFLAGS="$CFLAGS"    # save
CFLAGS="$CFLAGS $EXTRA_CFLAGS -Werror"

Otherwise I agree, but this relies on gcc-specific -Werror flag, which I'd rather not do. At least it would need some generic fallback mechanism..

Attachment: PGP.sig
Description: This is a digitally signed message part

Reply via email to