I don't think using dol_getmypid in scripts is a wise idea. The whole purpose of outputting the PID in the CLI is to be able to kill the process. We don't want to display a random number! People having the right to execute scripts on their hosting should have the right to use the getmypid() function anyway.
Also, the getmypid usage in TCPDF is just to get some entropy to generate a random seed. We could have removed it altogether because there is already quite a lot of entropy in the other parameters inferred. My 2 cents. This is a verbatim copy of my comment at https://github.com/Dolibarr/dolibarr/commit/212e9825a3974bbef19f96405c26eae63eb0a828#commitcomment-7252125 Cheers, 2014-08-01 9:44 GMT+02:00 Florian HENRY <florian.he...@open-concept.pro>: > Hello Marcos > > It come from the french forum ( > http://www.dolibarr.fr/forum/3-installation/50977-probleme-d-installation-chez-un-hebergeur-gratuit > ) > Some free hosting service remove getmypid for security reason. As this is > not a real must have for dolibarr running, a developper send this pull > request, and Laurent integrate it. > > Regards > > Florian Henry+33 6 03 76 48 > 07florian.henry@open-concept.prohttp://www.open-concept.pro > Twitter : @_Open_Concept_ > Google+ : https://plus.google.com/+FlorianHENRY > > Le 31/07/2014 20:26, Marcos García a écrit : > > Hi all: > > I've noticed a PR made by frederic ( > https://github.com/Dolibarr/dolibarr/pull/1792) was accepted, and so > getmypid was renamed to dol_getmypid. > > My question is: why was that made? The check if function does not exists > before recreating the function getmypid wasn't enough? > > I brought the discussion to the ML because I think it is a better place > to discuss this things. > > Regards, > > > *Marcos García* > > marcos...@gmail.com > > > > _______________________________________________ > Dolibarr-dev mailing > listDolibarr-dev@nongnu.orghttps://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > > > _______________________________________________ > Dolibarr-dev mailing list > Dolibarr-dev@nongnu.org > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > -- *Raphaël Doursenaud* Directeur technique (CTO) Expert certifié en déploiement Google Apps <https://gpcsolutions.fr/raphael-doursenaud-google-apps-certified-deployment-specialist> +33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10 -- <http://gpcsolutions.fr> http://gpcsolutions.fr Technopole Hélioparc 2 avenue du Président Pierre Angot 64053 PAU CEDEX 9 SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921 <https://www.google.com/a/partnersearch/#partner?partner_id=46687933_a0n60000000sqpWAAQ> <http://wiki.dolibarr.org/index.php/Dolibarr_suppliers_France#GPC.solutions>
_______________________________________________ Dolibarr-dev mailing list Dolibarr-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
