So ok to keep dolibarr functions but using the native php code inside instead (for compatibility reason + it help when native function need t obe extended)
2014-07-18 10:17 GMT+02:00 [Kreiz IT]Cédric GROSS <c.gr...@kreiz-it.fr>: > Hello, > > > > I agree. Just do a wrapper. And may be review also GETPOST to use also > filter_var or more precisely filter_input ;) > > > > Cedric > > > > *De :* dolibarr-dev-bounces+c.gross=kreiz-it...@nongnu.org [mailto: > dolibarr-dev-bounces+c.gross=kreiz-it...@nongnu.org] *De la part de* > Florian Henry > *Envoyé :* vendredi 18 juillet 2014 10:09 > *À :* Posts about Dolibarr ERP & CRM development and coding > *Objet :* Re: [Dolibarr-dev] Question about isValidUrl function > > > > I think that native PHP fonction is now OK to ne use everywhere. > > Envoyer depuis mon mobile. > > > "Doursenaud, Raphaël" <rdoursen...@gpcsolutions.fr> a écrit : > > Hi Marcos, > > > > I wouldn't delete parameters because there may be some external modules > that rely on this function. > > But I think we could benefit from using it as a wrapper to php native > functions and maybe deprecate it so module developers know they should use > the native functions directly. > > > > What do you think? > > > > 2014-07-17 21:23 GMT+02:00 Marcos García <marcos...@gmail.com>: > > Hi all: > > > > I've been looking at isValidUrl function (located in > core/lib/functions2.lib.php) and it has multiple parameters that are not > used all over Dolibarr code. > > > > > https://github.com/Dolibarr/dolibarr/blob/develop/htdocs/core/lib/functions2.lib.php#405 > > > > Also, there's already a function in the core of PHP that does the same. > Can we replace all the preg checks (that have high CPU cost) with the > filter_var function or is there any reason why those checks are there? > > > > > > > > Regards, > > > > *Marcos García* > > marcos...@gmail.com > > > _______________________________________________ > Dolibarr-dev mailing list > Dolibarr-dev@nongnu.org > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > > > > > -- > > *Raphaël Doursenaud* > > Directeur technique (CTO) > > Expert certifié en déploiement Google Apps > <https://gpcsolutions.fr/raphael-doursenaud-google-apps-certified-deployment-specialist> > > +33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10 > > > > [image: Image supprimée par l'expéditeur.] <http://gpcsolutions.fr> > > http://gpcsolutions.fr > > Technopole Hélioparc > > 2 avenue du Président Pierre Angot > > 64053 PAU CEDEX 9 > > SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921 > > [image: Image supprimée par l'expéditeur.] > <https://www.google.com/a/partnersearch/#partner?partner_id=46687933_a0n60000000sqpWAAQ>[image: > Image supprimée par l'expéditeur.] > <http://wiki.dolibarr.org/index.php/Dolibarr_suppliers_France#GPC.solutions> > > _______________________________________________ > Dolibarr-dev mailing list > Dolibarr-dev@nongnu.org > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > -- Laurent Destailleur (alias Eldy) ------------------------------------------------------------------------------------ Social networks of my OpenSource projects: Dolibarr Google+: https://plus.google.com/+DolibarrOrg/ Dolibarr Facebook: https://www.facebook.com/dolibarr Dolibarr Twitter: http://www.twitter.com/dolibarr AWStats Google+: https://plus.google.com/+AWStatsOrgPoject/ AWStats Facebook: https://www.facebook.com/awstats.org AWStats Twitter: http://www.twitter.com/awstats_project
_______________________________________________ Dolibarr-dev mailing list Dolibarr-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
