Hello all,

As de devcamp coming soon, I start to review code quality with PHP Code Sniffer (as describe into wiki optionnal tools pages).

I'm actually reviwing the note/private/public code (task 811 <https://doliforge.org/tracker/?func=detail&aid=811&group_id=144>) and projet module (task 772 <https://doliforge.org/tracker/?func=detail&aid=772&atid=247&group_id=144>).

During this review I see some strange code like "and" instead of "&&" into if test statement or for array "$array[code]" instead of "$array['code']". The PHP Code Sniffer show it immediatly and it's easy to correct.

This mail is to know if somebody know how to personnalize a little more the file dev/codesniffer/ruleset.xml to add a rule to say that $_POST or $_GET have to be replace by GETPOST dolibarr function ?

Kind regards

--
Florian HENRY
florian.he...@open-concept.pro
+33 6 03 76 48 07
http://www.open-concept.pro
Twitter : @_Open_Concept_

_______________________________________________
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

Répondre à