> On 3 Aug 2015, at 22:14, Wessels, Duane <dwess...@verisign.com> wrote: > > > I offered to review this document during the WG meeting in Prague…
Hi Duane, Many thanks for the detailed review. They are all useful comments that will be added to the document. > >> >> 3.1. Option Format >> >> The edns-tcp-keepalive option is encoded as follows: >> >> 1 2 3 >> 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 >> +-------------------------------+-------------------------------+ >> ! OPTION-CODE ! OPTION-LENGTH ! >> +-------------------------------+-------------------------------+ >> | TIMEOUT | >> +---------------------------------------------------------------+ >> >> where: >> >> OPTION-CODE: the EDNS0 option code assigned to edns-tcp-keepalive, >> [TBD] >> >> OPTION-LENGTH: the value 0 if the TIMEOUT is omitted, the value 2 >> if it is present; > >> >> TIMEOUT: an idle timeout value for the TCP connection, specified in >> units of 100 milliseconds, encoded in network byte order. > > > The diagram above indicates TIMEOUT is a 32-bit value, which would make > OPTION-LENGTH 4. > > I suspect it was really intended as a 16-bit value (OPTION-LENGTH 2), which > means the max TIMEOUT is around 109 minutes? > Well spotted. The diagram is incorrect - the timeout is intended to be a 16-bit value as you describe. Regards Sara. _______________________________________________ DNSOP mailing list DNSOP@ietf.org https://www.ietf.org/mailman/listinfo/dnsop
