On Tue, Jun 13, 2023 at 01:13:54PM +0000, David Laight wrote: > From: Andy Shevchenko > > Sent: 12 June 2023 22:48 > > > > The kernel already has a helper to print a hexdump of a small > > buffer via pointer extension. Use that instead of open coded > > variant. > > > > In long term it helps to kill pr_cont() or at least narrow down > > its use. > > > > Note, the format is slightly changed, i.e. the colon is not printed > > before the buffer dump and the trailing space is always printed. > > These are not a problem since it's a debug message. Also the IV dump > > is limited by 64 bytes which seems fine. > ... > > +#define DEBUG_bytes(bytes, len, msg, ...) printk(KERN_DEBUG msg " > > %*ph\n", ##__VA_ARGS__, len, > > bytes) > > Using: > printf(KERN_DEBUG msg "%s%*ph\n", ##__VA_ARGS__, len ? ": " : "", len, > bytes) > would add back the optional ':'.
Yes, I considered that and decided to avoid. This is debug and hence the format may vary anyway. That said, up to maintainers. -- With Best Regards, Andy Shevchenko -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
