On 4/18/23 15:12, Sarthak Kukreti wrote:
        /* Fail if we don't recognize the flags. */
-       if (mode & ~BLKDEV_FALLOC_FL_SUPPORTED)
+       if (mode != 0 && mode & ~BLKDEV_FALLOC_FL_SUPPORTED)
                return -EOPNOTSUPP;

Is this change necessary? Doesn't (mode & ~BLKDEV_FALLOC_FL_SUPPORTED) != 0 imply that mode != 0?

Thanks,

Bart.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Reply via email to