[dm-devel] [PATCH v4 08/18] nvme: Don't hardcode the data len for pr commands

[Mike Christie]

Reservation Report support needs to pass in a variable sized buffer, so
this patch has the pr command helpers take a data length argument.

Signed-off-by: Mike Christie <michael.chris...@oracle.com>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Reviewed-by: Keith Busch <kbu...@kernel.org>
Reviewed-by: Chaitanya Kulkarni <k...@nvidia.com>
---
 drivers/nvme/host/core.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index ba6f1911f7ea..6323ff79386a 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2072,7 +2072,7 @@ static char nvme_pr_type(enum pr_type type)
 }
 
 static int nvme_send_ns_head_pr_command(struct block_device *bdev,
-               struct nvme_command *c, u8 data[16])
+               struct nvme_command *c, u8 *data, unsigned int data_len)
 {
        struct nvme_ns_head *head = bdev->bd_disk->private_data;
        int srcu_idx = srcu_read_lock(&head->srcu);
@@ -2081,17 +2081,17 @@ static int nvme_send_ns_head_pr_command(struct 
block_device *bdev,
 
        if (ns) {
                c->common.nsid = cpu_to_le32(ns->head->ns_id);
-               ret = nvme_submit_sync_cmd(ns->queue, c, data, 16);
+               ret = nvme_submit_sync_cmd(ns->queue, c, data, data_len);
        }
        srcu_read_unlock(&head->srcu, srcu_idx);
        return ret;
 }
        
 static int nvme_send_ns_pr_command(struct nvme_ns *ns, struct nvme_command *c,
-               u8 data[16])
+               u8 *data, unsigned int data_len)
 {
        c->common.nsid = cpu_to_le32(ns->head->ns_id);
-       return nvme_submit_sync_cmd(ns->queue, c, data, 16);
+       return nvme_submit_sync_cmd(ns->queue, c, data, data_len);
 }
 
 static int nvme_sc_to_pr_err(int nvme_sc)
@@ -2131,10 +2131,11 @@ static int nvme_pr_command(struct block_device *bdev, 
u32 cdw10,
 
        if (IS_ENABLED(CONFIG_NVME_MULTIPATH) &&
            bdev->bd_disk->fops == &nvme_ns_head_ops)
-               ret = nvme_send_ns_head_pr_command(bdev, &c, data);
+               ret = nvme_send_ns_head_pr_command(bdev, &c, data,
+                                                  sizeof(data));
        else
                ret = nvme_send_ns_pr_command(bdev->bd_disk->private_data, &c,
-                                             data);
+                                             data, sizeof(data));
        if (ret < 0)
                return ret;
 
-- 
2.25.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel