Hi Jane, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on nvdimm/libnvdimm-for-next] [also build test WARNING on device-mapper-dm/for-next linus/master v5.17-rc8 next-20220318] [cannot apply to tip/x86/mm] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jane-Chu/DAX-poison-recovery/20220319-143144 base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next config: s390-randconfig-r044-20220317 (https://download.01.org/0day-ci/archive/20220319/[email protected]/config) compiler: s390-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/203570f765a6ad07eb5809850478a25a5257f7e2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jane-Chu/DAX-poison-recovery/20220319-143144 git checkout 203570f765a6ad07eb5809850478a25a5257f7e2 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash fs/fuse/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All warnings (new ones prefixed by >>): fs/fuse/virtio_fs.c: In function 'virtio_fs_zero_page_range': >> fs/fuse/virtio_fs.c:774:58: warning: passing argument 4 of >> 'dax_direct_access' makes integer from pointer without a cast >> [-Wint-conversion] 774 | rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL); | ^~~~~~ | | | void ** In file included from fs/fuse/virtio_fs.c:8: include/linux/dax.h:187:21: note: expected 'int' but argument is of type 'void **' 187 | int flags, void **kaddr, pfn_t *pfn); | ~~~~^~~~~ fs/fuse/virtio_fs.c:774:14: error: too few arguments to function 'dax_direct_access' 774 | rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL); | ^~~~~~~~~~~~~~~~~ In file included from fs/fuse/virtio_fs.c:8: include/linux/dax.h:186:6: note: declared here 186 | long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages, | ^~~~~~~~~~~~~~~~~ fs/fuse/virtio_fs.c: At top level: fs/fuse/virtio_fs.c:783:26: error: initialization of 'long int (*)(struct dax_device *, long unsigned int, long int, int, void **, pfn_t *)' from incompatible pointer type 'long int (*)(struct dax_device *, long unsigned int, long int, void **, pfn_t *)' [-Werror=incompatible-pointer-types] 783 | .direct_access = virtio_fs_direct_access, | ^~~~~~~~~~~~~~~~~~~~~~~ fs/fuse/virtio_fs.c:783:26: note: (near initialization for 'virtio_fs_dax_ops.direct_access') cc1: some warnings being treated as errors vim +/dax_direct_access +774 fs/fuse/virtio_fs.c 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 767 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 768 static int virtio_fs_zero_page_range(struct dax_device *dax_dev, 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 769 pgoff_t pgoff, size_t nr_pages) 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 770 { 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 771 long rc; 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 772 void *kaddr; 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 773 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 @774 rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL); 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 775 if (rc < 0) 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 776 return rc; 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 777 memset(kaddr, 0, nr_pages << PAGE_SHIFT); 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 778 dax_flush(dax_dev, kaddr, nr_pages << PAGE_SHIFT); 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 779 return 0; 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 780 } 22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 781 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/[email protected]
