On Thu, Nov 11 2021 at  2:56P -0500,
cgel....@gmail.com <cgel....@gmail.com> wrote:

> From: ran jianping <ran.jianp...@zte.com.cn>
> 
> Fix the following coccicheck review:
> ./drivers/md/dm-snap-transient.c:91:10-12: Unneeded variable
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zea...@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianp...@zte.com.cn>
> ---
>  drivers/md/dm-snap-transient.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-snap-transient.c b/drivers/md/dm-snap-transient.c
> index 0e0ae4c36b37..d95b59855da0 100644
> --- a/drivers/md/dm-snap-transient.c
> +++ b/drivers/md/dm-snap-transient.c
> @@ -88,7 +88,6 @@ static unsigned transient_status(struct dm_exception_store 
> *store,
>                                status_type_t status, char *result,
>                                unsigned maxlen)
>  {
> -     unsigned sz = 0;
>  
>       switch (status) {
>       case STATUSTYPE_INFO:
> @@ -101,7 +100,7 @@ static unsigned transient_status(struct 
> dm_exception_store *store,
>               break;
>       }
>  
> -     return sz;
> +     return 0;
>  }
>  
>  static struct dm_exception_store_type _transient_type = {
> -- 
> 2.25.1
> 

You clearly didn't even compile test this.

Nacked-by: Mike Snitzer <snit...@redhat.com>

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Reply via email to