Hi Jane, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on device-mapper-dm/for-next] [also build test WARNING on nvdimm/libnvdimm-for-next mszeredi-fuse/for-next linus/master v5.15-rc6 next-20211021] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jane-Chu/dax-poison-recovery-with-RWF_RECOVERY_DATA-flag/20211021-081336 base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next config: i386-debian-10.3 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/a01994a484c54b2f4b6eb32104ab3caf7b9b32a8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jane-Chu/dax-poison-recovery-with-RWF_RECOVERY_DATA-flag/20211021-081336 git checkout a01994a484c54b2f4b6eb32104ab3caf7b9b32a8 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/blk_types.h:11, from include/linux/genhd.h:19, from include/linux/blkdev.h:8, from drivers/nvdimm/pmem.c:10: drivers/nvdimm/pmem.c: In function 'pmem_copy_from_iter': >> drivers/nvdimm/pmem.c:336:19: warning: format '%lx' expects argument of type >> 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} >> [-Wformat=] 336 | dev_warn(dev, "Found poison, but addr(%p) and/or bytes(%#lx) not page aligned\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ include/linux/dev_printk.h:146:54: note: in expansion of macro 'dev_fmt' 146 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~ drivers/nvdimm/pmem.c:336:5: note: in expansion of macro 'dev_warn' 336 | dev_warn(dev, "Found poison, but addr(%p) and/or bytes(%#lx) not page aligned\n", | ^~~~~~~~ drivers/nvdimm/pmem.c:336:63: note: format string is defined here 336 | dev_warn(dev, "Found poison, but addr(%p) and/or bytes(%#lx) not page aligned\n", | ~~~^ | | | long unsigned int | %#x vim +336 drivers/nvdimm/pmem.c 306 307 /* 308 * Even though the 'no check' versions of copy_from_iter_flushcache() 309 * and copy_mc_to_iter() are used to bypass HARDENED_USERCOPY overhead, 310 * 'read'/'write' aren't always safe when poison is consumed. They happen 311 * to be safe because the 'read'/'write' range has been guaranteed 312 * be free of poison(s) by a prior call to dax_direct_access() on the 313 * caller stack. 314 * However with the introduction of DAXDEV_F_RECOVERY, the 'read'/'write' 315 * range may contain poison(s), so the functions perform explicit check 316 * on poison, and 'read' end up fetching only non-poisoned page(s) up 317 * till the first poison is encountered while 'write' require the range 318 * is page aligned in order to restore the poisoned page's memory type 319 * back to "rw" after clearing the poison(s). 320 * In the event of poison related failure, (size_t) -EIO is returned and 321 * caller may check the return value after casting it to (ssize_t). 322 */ 323 static size_t pmem_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, 324 void *addr, size_t bytes, struct iov_iter *i, unsigned long flags) 325 { 326 phys_addr_t pmem_off; 327 size_t len, lead_off; 328 struct pmem_device *pmem = dax_get_private(dax_dev); 329 struct device *dev = pmem->bb.dev; 330 331 if (flags & DAXDEV_F_RECOVERY) { 332 lead_off = (unsigned long)addr & ~PAGE_MASK; 333 len = PFN_PHYS(PFN_UP(lead_off + bytes)); 334 if (is_bad_pmem(&pmem->bb, PFN_PHYS(pgoff) / 512, len)) { 335 if (lead_off || !(PAGE_ALIGNED(bytes))) { > 336 dev_warn(dev, "Found poison, but > addr(%p) and/or bytes(%#lx) not page aligned\n", 337 addr, bytes); 338 return (size_t) -EIO; 339 } 340 pmem_off = PFN_PHYS(pgoff) + pmem->data_offset; 341 if (pmem_clear_poison(pmem, pmem_off, bytes) != 342 BLK_STS_OK) 343 return (size_t) -EIO; 344 } 345 } 346 347 return _copy_from_iter_flushcache(addr, bytes, i); 348 } 349 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
-- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel
