Hi SelvaKumar,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on block/for-next]
[also build test WARNING on dm/for-next next-20210817]
[cannot apply to linus/master linux-nvme/for-next v5.14-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/SelvaKumar-S/block-make-bio_map_kern-non-static/20210817-193111
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git 
for-next
config: hexagon-randconfig-r013-20210816 (attached as .config)
compiler: clang version 12.0.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/c307f1051a72122d636502c6885df8b2b25ed697
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
SelvaKumar-S/block-make-bio_map_kern-non-static/20210817-193111
        git checkout c307f1051a72122d636502c6885df8b2b25ed697
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

   block/blk-lib.c:197:5: warning: no previous prototype for function 
'blk_copy_offload_submit_bio' [-Wmissing-prototypes]
   int blk_copy_offload_submit_bio(struct block_device *bdev,
       ^
   block/blk-lib.c:197:1: note: declare 'static' if the function is not 
intended to be used outside of this translation unit
   int blk_copy_offload_submit_bio(struct block_device *bdev,
   ^
   static 
   block/blk-lib.c:250:5: warning: no previous prototype for function 
'blk_copy_offload_scc' [-Wmissing-prototypes]
   int blk_copy_offload_scc(struct block_device *src_bdev, int nr_srcs,
       ^
   block/blk-lib.c:250:1: note: declare 'static' if the function is not 
intended to be used outside of this translation unit
   int blk_copy_offload_scc(struct block_device *src_bdev, int nr_srcs,
   ^
   static 
>> block/blk-lib.c:336:5: warning: no previous prototype for function 
>> 'blk_submit_rw_buf' [-Wmissing-prototypes]
   int blk_submit_rw_buf(struct block_device *bdev, void *buf, sector_t buf_len,
       ^
   block/blk-lib.c:336:1: note: declare 'static' if the function is not 
intended to be used outside of this translation unit
   int blk_submit_rw_buf(struct block_device *bdev, void *buf, sector_t buf_len,
   ^
   static 
   3 warnings generated.


vim +/blk_submit_rw_buf +336 block/blk-lib.c

   335  
 > 336  int blk_submit_rw_buf(struct block_device *bdev, void *buf, sector_t 
 > buf_len,
   337                                  sector_t sector, unsigned int op, gfp_t 
gfp_mask)
   338  {
   339          struct request_queue *q = bdev_get_queue(bdev);
   340          struct bio *bio, *parent = NULL;
   341          sector_t max_hw_len = min_t(unsigned int, 
queue_max_hw_sectors(q),
   342                          queue_max_segments(q) << (PAGE_SHIFT - 
SECTOR_SHIFT));
   343          sector_t len, remaining;
   344          int ret;
   345  
   346          for (remaining = buf_len; remaining > 0; remaining -= len) {
   347                  len = min_t(int, max_hw_len, remaining);
   348  retry:
   349                  bio = bio_map_kern(q, buf, len << SECTOR_SHIFT, 
gfp_mask);
   350                  if (IS_ERR(bio)) {
   351                          len >>= 1;
   352                          if (len)
   353                                  goto retry;
   354                          return PTR_ERR(bio);
   355                  }
   356  
   357                  bio->bi_iter.bi_sector = sector;
   358                  bio->bi_opf = op;
   359                  bio_set_dev(bio, bdev);
   360                  bio->bi_end_io = NULL;
   361                  bio->bi_private = NULL;
   362  
   363                  if (parent) {
   364                          bio_chain(parent, bio);
   365                          submit_bio(parent);
   366                  }
   367                  parent = bio;
   368                  sector += len;
   369          }
   370          ret = submit_bio_wait(bio);
   371          bio_put(bio);
   372  
   373          return ret;
   374  }
   375  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

Reply via email to