On Tue, Sep 15, 2020 at 01:16:19PM +0200, Martin Wilck wrote: > On Sat, 2020-08-22 at 00:42 +0200, [email protected] wrote: > > From: Martin Wilck <[email protected]> > > > > Hi Christophe, hi Ben, > > > > embarassingly, it turns out that my unit test code for the bitfield > > code was broken in various ways, which at the same time shows that > > I didn't test this as broadly as I should have before submitting. > > The good news is that only the test code was broken, not the > > implementation itself. > > > > With these fixes, I successfully compiled it on both little and > > big endian architectures, with and without glibc 2.27. > > (https://build.opensuse.org/package/show/Base:System/multipath-tools) > > > > Regards, > > Martin > > > > Martin Wilck (3): > > multipath-tools tests: fix bitfield tests for small fields > > multipath-tools tests: fix bitfield tests for big endian > > multipath-tools tests: fix small bitfield tests for big endian > > > > tests/util.c | 146 ++++++++++++++++++++++++++++++++++++++++++------- > > -- > > 1 file changed, 120 insertions(+), 26 deletions(-) > > @Ben: Gentle review reminder ...
Reviewed-by: Benjamin Marzinski <[email protected]> > > Cheers, > Martin > > -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
