Found by coverity.

Signed-off-by: Hannes Reinecke <[email protected]>
---
 libmultipath/discovery.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index db82b00..5d5441d 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -1179,16 +1179,17 @@ ccw_sysfs_pathinfo (struct path * pp)
         */
        attr_path = udev_device_get_sysname(parent);
        pp->sg_id.lun = 0;
-       sscanf(attr_path, "%i.%i.%x",
-                       &pp->sg_id.host_no,
-                       &pp->sg_id.channel,
-                       &pp->sg_id.scsi_id);
-       condlog(3, "%s: h:b:t:l = %i:%i:%i:%i",
+       if (sscanf(attr_path, "%i.%i.%x",
+                  &pp->sg_id.host_no,
+                  &pp->sg_id.channel,
+                  &pp->sg_id.scsi_id) == 3) {
+               condlog(3, "%s: h:b:t:l = %i:%i:%i:%i",
                        pp->dev,
                        pp->sg_id.host_no,
                        pp->sg_id.channel,
                        pp->sg_id.scsi_id,
                        pp->sg_id.lun);
+       }
 
        return 0;
 }
-- 
2.6.6

--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to