On Mon, Mar 16, 2026 at 10:58:39AM -0700, Bart Van Assche wrote: > On 3/16/26 9:37 AM, Mikulas Patocka wrote: > > +#define KEEP_OPEN_DEVICES 1 > > +#define MARK_DEFERRED 2 > > +#define ONLY_DEFERRED 4 > > +#define INTERRUPTIBLE 8 > Has it been considered to add a (short) prefix to these flag names?
And shouldn't this be an enum? Yes, the dm code currently flaps between both styles. | Enums are preferred when defining several related constants. https://www.kernel.org/doc/html/v6.19/process/coding-style.html#macros-enums-and-rtl And maybe even "(1 << 0)" to make them easier visible as flags. Bastian -- I'm a soldier, not a diplomat. I can only tell the truth. -- Kirk, "Errand of Mercy", stardate 3198.9
