On 9/10/25 23:02, Bart Van Assche wrote: > > On 9/9/25 6:38 PM, Damien Le Moal wrote: >> Then please rewrite the commit message to clearly state that and add Fixes >> tags >> as appropriate. > > Hi Damien, > > Do we agree that sending REQ_PREFLUSH and data as a single bio instead > of as two bios is a performance optimization that neither affects which > data gets written nor the behavior in case of a power failure? Do we > agree that the Fixes tag should only be used for bug fixes and not for > performance optimizations?
Yes, fixes tag apply to patches that fix a problem. I know that. Your commit message was mentioning a problem but was not clear since it was mingled with write pipelining, which is not upstream. For the REQ_PREFLUSH, I did spend a lot of time with the flush machinery to get it to work with zone write plugging (when I was developing that). I probably should have spent more time with DM handling of that request. I do not recall exactly what it does. Would need to reread the code, but I am too busy for that until next week. So I cannot comment about what you are trying to do. Make your commit message clearer to help reviewing please. -- Damien Le Moal Western Digital Research
