On Mon, 2025-09-08 at 14:34 -0400, Benjamin Marzinski wrote:
> On Fri, Sep 05, 2025 at 11:07:13PM +0200, Martin Wilck wrote:
> > Coverity scan defect #488155.
> > 
> 
> Your fix looks fine, but the code I see right above it isn't. We
> should
> not be returning a positive number here if things went wrong. Looking
> at the udev_enumerate_new() code, we should be safe always trusting
> it to
> set errno correctly. So, the code should probably be
> 
> if (!enm)
>       return -errno; 
> 
> If you don't want to handle that is this commit then:

Right. I'll push another fix on top, using your suggestion.
Thanks for spotting it!

Martin

Reply via email to