Re: [PATCH] multipath-tools: fix default blacklist of s390 devices

[Xose Vazquez Perez]

On 7/19/25 2:34 PM, Martin Wilck wrote:

On Fri, 2025-07-18 at 22:54 +0200, Xose Vazquez Perez wrote:

On 7/14/25 2:38 PM, Stefan Haberland wrote:

Is PAV really supported on FBA devices ???
And other than 3390 and 3380(3390 model 2/3 in track-
compatibility mode) ECKD types ?

Currently there is no support in the driver for PAV with FBA
devices.
But the devices itself are capable of PAV.

If there is no PAV support for FBA devices on Linux, and it looks
like it won't be
implemented even in the distant future. The detection code, and the
device, could
be deleted from multipath-tools:

I agree. @Stefan, it would be appreciated if you or someone from your
group could send a patch.

Something like (untested!):

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index 31db8758..4fc0c496 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -1677,11 +1677,9 @@ ccw_sysfs_pathinfo (struct path *pp, const struct 
vector_s *hwtable)
        if (sysfs_get_devtype(parent, attr_buff, FILE_NAME_SIZE) <= 0)
                return PATHINFO_FAILED;

-       if (!strncmp(attr_buff, "3370", 4)) {
-               sprintf(pp->product_id,"S/390 DASD FBA");
-       } else if (!strncmp(attr_buff, "9336", 4)) {
-               sprintf(pp->product_id,"S/390 DASD FBA");
-       } else {
+       // PAV is only supported on ECKD devices.
+       // Defined in drivers/s390/block/dasd_eckd.c
+       if (!strncmp(attr_buff, "3390", 4) || !strncmp(attr_buff, "3380", 4)) {
                sprintf(pp->product_id,"S/390 DASD ECKD");
        }

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 4ca4245c..8e052147 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -674,7 +674,8 @@ static struct hwentry default_hw[] = {
                .no_path_retry = NO_PATH_RETRY_QUEUE,
        },
        {
-               /* PAV DASD ECKD */
+               // PAV DASD ECKD
+               // "ECKD devices" enumerated in: libmultipath/discovery.c
                .vendor        = "IBM",
                .product       = "S/390 DASD ECKD",
                .bl_product    = "S/390 DASD ECKD",
@@ -683,16 +684,6 @@ static struct hwentry default_hw[] = {
                .pgpolicy      = MULTIBUS,
                .checker_name  = DIRECTIO,
        },
-       {
-               /* PAV DASD FBA */
-               .vendor        = "IBM",
-               .product       = "S/390 DASD FBA",
-               .bl_product    = "S/390 DASD FBA",
-               .uid_attribute = "ID_UID",
-               .no_path_retry = NO_PATH_RETRY_QUEUE,
-               .pgpolicy      = MULTIBUS,
-               .checker_name  = DIRECTIO,
-       },
        {
                /* Power RAID */
                .vendor        = "IBM",