On 11/07/2025 09:42, Damien Le Moal wrote:
diff --git a/block/blk-settings.c b/block/blk-settings.c
index a000daafbfb48..a2c089167174e 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -180,6 +180,7 @@ static void blk_atomic_writes_update_limits(struct
queue_limits *lim)
static void blk_validate_atomic_write_limits(struct queue_limits *lim)
{
+ unsigned long long chunk_bytes = lim->chunk_sectors << SECTOR_SHIFT;
Don't you need to cast to a 64-bits "lim->chunk_sectors" here ?
I thought that we automatically convert lim->chunk_sectors to unsigned
long long, but I think that you are right...
At this point I think that it's easier to just convert
atomic_write_hw_max to sectors and do that comparison
Thanks,
John
