On Mon, 19 May 2025, Yu Kuai wrote:

> Hi,
> 
> 在 2025/05/19 9:11, Yu Kuai 写道:
> > Hi,
> > 
> > 在 2025/05/17 0:00, Mikulas Patocka 写道:
> > > Hi
> > > 
> > > The commit e879a0d9cb086c8e52ce6c04e5bfa63825a6213c breaks the test
> > > shell/lvcreate-large-raid.sh in the lvm2 testsuite.
> > > 
> > > The breakage is caused by removing the line "read_bio->bi_opf = op |
> > > do_sync;"
> > > 
> > 
> > Sorry that I don't undertand here, before the patch:
> > 
> > op = bio_op(bio);
> > do_sync = bio->bi_opf & REQ_SYNC;
> > read_bio->bi_opf = op | do_sync
> > 
> > after the patch:
> > 
> > read_bio = bio_alloc_clone(, bio, ...)
> >   read_bio->bi_opf = bio->bi_opf
> > 
> > So, after the patch, other than bio_op() and REQ_SYNC, other bio flags
> > are keeped, I don't see problem for now, I'll run the test later.
> > 
> 
> Do I need some special setup to run this test? I got following
> result in my VM, and I don't understand why it failed.
> 
> Thanks,
> Kuai

Ask Zdenek Kabelac - he is expert in the testsuite.

Mikulas

Reply via email to