On 5/15/25 12:11, Kevin Wolf wrote:
The thing that we need to make sure, though, is that the emulated status we can expose to the guest is actually good enough. That Paolo said that the problem with reservation conflicts was mostly because -EBADE wasn't a thing yet gives me some hope that at least this wouldn't be a problem any more today.
Hmm I'm not sure about that anymore... I was confused because some of the refactoring of block errors was done in 2017, which is around the same time I was working on persistent reservations in QEMU.
However, EBADE handling dates back to 2011 (commit 63583cca745f, "[SCSI] Add detailed SCSI I/O errors", 2011-02-12) and yet the Windows tests for PR were failing before QEMU switched to SG_IO for reads and writes. I guess I have to try reverting that and retest, though.
Paolo
