Hello Xose, On Fri, 2025-05-09 at 14:54 +0200, Xose Vazquez Perez wrote: > codespell: > ./tests/mapinfo.c:964: ouput ==> output > ./libmultipath/devmapper.h:118: paramters ==> parameters > ./libmpathutil/uxsock.c:69: everone ==> everyone
As you may know, a spell checker is part of our regular GitHub CI [1]. This checker has found a large amount of spelling errors in our code base when we first tried it. We therefore decided to restrict it to user-visible parts of the code, i.e. error messages, man pages, READMEs etc. While there's nothing wrong with your patch per se, I am hesitant to apply it, because if we start fixing spelling errors in comments, we should be consequent and eliminate all spelling mistakes, which would cause a large number of code changes that are irrelevant to functionality. That, in turn, would make it more difficult to assess future code changes for regressions and bug fixes. I'd like to continue following a policy of small changes. That means that we fix things like indentation, formatting, whitespace, and spelling only in those places of the code which we actually make changes for. This is just my personal preference of course. I'm open for discussion. Regards Martin [1] https://github.com/opensvc/multipath-tools/actions/workflows/spelling.yml > > =============== > SUMMARY: > everone 1 > ouput 1 > paramters 1 > > Cc: Martin Wilck <mwi...@suse.com> > Cc: Benjamin Marzinski <bmarz...@redhat.com> > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: DM-DEVEL ML <dm-devel@lists.linux.dev> > Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com> > --- > libmpathutil/uxsock.c | 2 +- > libmultipath/devmapper.h | 2 +- > tests/mapinfo.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libmpathutil/uxsock.c b/libmpathutil/uxsock.c > index 59c47170..02b387d0 100644 > --- a/libmpathutil/uxsock.c > +++ b/libmpathutil/uxsock.c > @@ -66,7 +66,7 @@ int ux_socket_listen(const char *name) > } > > /* > - * Socket needs to have rw permissions for everone. > + * Socket needs to have rw permissions for everyone. > * SO_PEERCRED makes sure that only root can modify things. > */ > if (name[0] != '@' && > diff --git a/libmultipath/devmapper.h b/libmultipath/devmapper.h > index 4aeefad1..c0f7aa0d 100644 > --- a/libmultipath/devmapper.h > +++ b/libmultipath/devmapper.h > @@ -115,7 +115,7 @@ typedef struct libmp_map_info { > * > * This function obtains the requested information for the device- > mapper map > * identified by the input parameters. > - * If non-NULL, the name, uuid, and dmi output paramters may be > filled in for > + * If non-NULL, the name, uuid, and dmi output parameters may be > filled in for > * any return value besides DMP_NOT_FOUND and will always be filled > in for > * return values other than DMP_NOT_FOUND and DMP_ERR. > * The other parameters are only filled in if the return value is > DMP_OK. > diff --git a/tests/mapinfo.c b/tests/mapinfo.c > index 36511607..399e16e7 100644 > --- a/tests/mapinfo.c > +++ b/tests/mapinfo.c > @@ -961,7 +961,7 @@ static void test_mapinfo_bad_target_type_03(void > **state) > (mapid_t) { .str = "foo", }, > (mapinfo_t) { .dmi = &dmi, .name = name, > .uuid = uuid }); > assert_int_equal(rc, DMP_NO_MATCH); > - /* make sure that the ouput was filled in */ > + /* make sure that the output was filled in */ > assert_memory_equal(&dmi, &MPATH_DMI_01, sizeof(dmi)); > assert_true(!strcmp(name, MPATH_NAME_01)); > assert_true(!strcmp(uuid, MPATH_UUID_01));