Found by Fedora's static analysis [1]. [1] https://openscanhub.fedoraproject.org/task/51915/log/device-mapper-multipath-0.11.1-1.fc43/scan-results.html#def68
Signed-off-by: Martin Wilck <mwi...@suse.com> Reviewed-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/prioritizers/iet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libmultipath/prioritizers/iet.c b/libmultipath/prioritizers/iet.c index f3bf64c..f5fdd42 100644 --- a/libmultipath/prioritizers/iet.c +++ b/libmultipath/prioritizers/iet.c @@ -101,6 +101,8 @@ int iet_prio(const char *dev, char * args) char buffer[BUFFERSIZE]; char fullpath[BUFFERSIZE] = "/dev/disk/by-path/"; dir_p = opendir(fullpath); + if (!dir_p) + goto out; // loop to find device in /dev/disk/by-path while( NULL != (dir_entry_p = readdir(dir_p))) { @@ -135,6 +137,7 @@ int iet_prio(const char *dev, char * args) } // nothing found, low prio closedir(dir_p); +out: return 10; } -- 2.49.0