Re: [PATCH 04/12] block: remove the blk_integrity_profile structure

[Bart Van Assche]

On 6/5/24 00:28, Christoph Hellwig wrote:

+const char *blk_integrity_profile_name(struct blk_integrity *bi)
+{
+       switch (bi->csum_type) {
+       case BLK_INTEGRITY_CSUM_IP:
+               if (bi->flags & BLK_INTEGRITY_REF_TAG)
+                       return "T10-DIF-TYPE1-IP";
+               return "T10-DIF-TYPE3-IP";
+       case BLK_INTEGRITY_CSUM_CRC:
+               if (bi->flags & BLK_INTEGRITY_REF_TAG)
+                       return "T10-DIF-TYPE1-CRC";
+               return "T10-DIF-TYPE3-CRC";
+       case BLK_INTEGRITY_CSUM_CRC64:
+               if (bi->flags & BLK_INTEGRITY_REF_TAG)
+                       return "EXT-DIF-TYPE1-CRC64";
+               return "EXT-DIF-TYPE3-CRC64";
+       default:
+               return "nop";
+       }
+}

Since bi->csum_type has an enumeration type, please leave out the "default:"
and move return "nop" outside the switch statement. This will make the
compiler issue a warning if a new enumeration label would be added without
updating the above switch statement. Otherwise this patch looks good to me.

Thanks,

Bart.