Re: [PATCH 3/7] libmultipath: print all values in snprint_failback

[Martin Wilck]

On Mon, 2024-05-13 at 13:36 -0400, Benjamin Marzinski wrote:
> Add the missing output for manual failback and print the defferral
> time
> for deferred failbacks, if one isn't currently in progress.
> 
> Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com>
> ---
>  libmultipath/print.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/libmultipath/print.c b/libmultipath/print.c
> index 89813517..14e7e325 100644
> --- a/libmultipath/print.c
> +++ b/libmultipath/print.c
> @@ -218,9 +218,13 @@ snprint_failback (struct strbuf *buff, const
> struct multipath * mpp)
>               return append_strbuf_str(buff, "immediate");
>       if (mpp->pgfailback == -FAILBACK_FOLLOWOVER)
>               return append_strbuf_str(buff, "followover");
> +     if (mpp->pgfailback == -FAILBACK_MANUAL)
> +             return append_strbuf_str(buff, "manual");
> +     if (mpp->pgfailback == FAILBACK_UNDEF)
> +             return append_strbuf_str(buff, "undef");
>  
>       if (!mpp->failback_tick)
> -             return append_strbuf_str(buff, "-");
> +             return print_strbuf(buff, "%i", mpp->pgfailback);

Perhaps we should print something like "delayed:%i" here?

Martin



>       else
>               return snprint_progress(buff, mpp->failback_tick,
>                                       mpp->pgfailback);