Re: [PATCH v5 07/14] md: export helpers to stop sync_thread

[Yu Kuai]

Hi,

在 2024/02/16 6:27, Song Liu 写道:

On Thu, Feb 1, 2024 at 1:30 AM Yu Kuai <yuku...@huaweicloud.com> wrote:

[...]

+
  static void idle_sync_thread(struct mddev *mddev)
  {
         mutex_lock(&mddev->sync_mutex);
-       clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);

         if (mddev_lock(mddev)) {
                 mutex_unlock(&mddev->sync_mutex);
                 return;
         }

+       clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
         stop_sync_thread(mddev, false, true);
         mutex_unlock(&mddev->sync_mutex);
  }
@@ -4936,13 +4965,13 @@ static void idle_sync_thread(struct mddev *mddev)
  static void frozen_sync_thread(struct mddev *mddev)
  {
         mutex_lock(&mddev->sync_mutex);
-       set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);

         if (mddev_lock(mddev)) {
                 mutex_unlock(&mddev->sync_mutex);
                 return;
         }

+       set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
         stop_sync_thread(mddev, false, false);
         mutex_unlock(&mddev->sync_mutex);
  }

The two changes above (moving set_bit) don't seem to belong
to this patch. If they are still needed, please submit a separate
patch.

Yes, they are not needed in this patchset. I forgot to remove them while
solving conflicts with other patches locally.

Thanks,
Kuai

Thanks,
Song

.