Eric Biggers <[email protected]> wrote: > > + driver_name = crypto_ahash_driver_name(ahash); > + if (v->version >= 1 /* salt prepended, not appended? */ && > + 1 << v->data_dev_block_bits <= PAGE_SIZE) { > + shash = crypto_alloc_shash(alg_name, 0, 0);
I'm sorry but this is disgusting. Can't we do the same optimisation for the ahash import+finup path? On a side note, if we're going to use shash for bulk data then we should reintroduce the can/cannot sleep flag. Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
