On Thu, Mar 11, 2010 at 10:01 PM, Brian Neal <bgn...@gmail.com> wrote:
> On Mar 7, 10:48 pm, Brian Neal <bgn...@gmail.com> wrote:
>> Before the Django 1.2 beta and the class-based Feed views, I was doing
>> this to cache my RSS feeds:
>>
>> urls.py:
>> from django.contrib.syndication.views import feed as syndication_feed
>> from django.views.decorators.cache import cache_page
>>
>> urlpatterns = patterns('',
>> url(r'^feeds/(?P<url>.*)/$',
>> cache_page(syndication_feed, 60 * 15),
>> {'feed_dict': feeds},
>> 'feeds-news'),
>>
>> Is there a way to do something similar to this now with the 1.2 Feed
>> classes? This doesn't seem to work when the argument to cache_page is
>> now an instance of a Feed object (I get an AttributeError; my feed
>> class has no attribute '__name__'):
>>
>> url(r'^feeds/news/$',
>> cache_page(LatestNewsFeed(), 60 * 15),
>> name='feeds-news'),
>>
>
> Well, I'm not sure if it was the intent to break this use case. Any
> thoughts?
Apologies for not replying earlier, Brian.
We didn't specifically aim to break this use case. I can't think of
any conceptual reason that you shouldn't be able to cache class-based
feeds; this looks to be entirely a technical problem caused by the
fact that cache_page doesn't work nicely with callable classes.
One quick workaround that seems to work in my testing is to add
exactly what is being asked for -- the cache_page decorator needs a
__name__ attribute... so provide one. Add a __name__ class attribute
to the feed class::
class LatestNewsFeed(Feed):
__name__ = 'LatestNewsFeed'
A better solution is for us to fix the cache_page decorator so that it
will look at __class__.__name__ (or some similar attribute) if
__name__ isn't available. I've added ticket #13093 to track this
problem, and I'll make sure it's addressed before 1.2 is released.
Yours,
Russ Magee %-)
--
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-us...@googlegroups.com.
To unsubscribe from this group, send email to
django-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en.
