Hi,
>
> > can't i put "from models import *" in the test code? what should i do?
>
> This happens if you import the same file using two different names. Eg, here
> you are importing it as 'from models import *'. In some other part of your
> code, you probably have 'from foo.models import *'. Python treats them as
> two different files, and hence the signal is attached twice.
>
Actually - it may not only be that. I've just run into this, too. I
stuck a pdb just before our signal connect, call, and saw that
models.py was indeed imported twice during the phase where Django's
test runner looks for tests to run. Compare these two stack traces,
from each time my pdb was hit:
(Pdb) w
/home/dan/virtual/mofin/trunk/bin/django(40)<module>()
-> djangorecipe.manage.main('mofinproject.settings')
/home/dan/.buildout/eggs/djangorecipe-0.19.1-py2.6.egg/djangorecipe/
manage.py(16)main()
-> management.execute_manager(mod)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
__init__.py(362)execute_manager()
-> utility.execute()
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
__init__.py(303)execute()
-> self.fetch_command(subcommand).run_from_argv(self.argv)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
base.py(195)run_from_argv()
-> self.execute(*args, **options.__dict__)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
base.py(222)execute()
-> output = self.handle(*args, **options)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
commands/test.py(23)handle()
-> failures = test_runner(test_labels, verbosity=verbosity,
interactive=interactive)
/home/dan/virtual/mofin/trunk/parts/django/django/test/simple.py(176)
run_tests()
-> suite.addTest(build_test(label))
/home/dan/virtual/mofin/trunk/parts/django/django/test/simple.py(85)
build_test()
-> app_module = get_app(parts[0])
/home/dan/virtual/mofin/trunk/parts/django/django/db/models/
loading.py(114)get_app()
-> self._populate()
/home/dan/virtual/mofin/trunk/parts/django/django/db/models/
loading.py(58)_populate()
-> self.load_app(app_name, True)
/home/dan/virtual/mofin/trunk/parts/django/django/db/models/
loading.py(74)load_app()
-> models = import_module('.models', app_name)
/home/dan/virtual/mofin/trunk/parts/django/django/utils/importlib.py
(35)import_module()
-> __import__(name)
> /home/dan/virtual/mofin/trunk/mofin/store/models.py(514)<module>()
-> models.signals.post_save.connect(flaggedentry_post_save,
sender=FlaggedEntry)
(Pdb)
... and ...
(Pdb) w
/home/dan/virtual/mofin/trunk/bin/django(40)<module>()
-> djangorecipe.manage.main('mofinproject.settings')
/home/dan/.buildout/eggs/djangorecipe-0.19.1-py2.6.egg/djangorecipe/
manage.py(16)main()
-> management.execute_manager(mod)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
__init__.py(362)execute_manager()
-> utility.execute()
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
__init__.py(303)execute()
-> self.fetch_command(subcommand).run_from_argv(self.argv)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
base.py(195)run_from_argv()
-> self.execute(*args, **options.__dict__)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
base.py(222)execute()
-> output = self.handle(*args, **options)
/home/dan/virtual/mofin/trunk/parts/django/django/core/management/
commands/test.py(23)handle()
-> failures = test_runner(test_labels, verbosity=verbosity,
interactive=interactive)
/home/dan/virtual/mofin/trunk/parts/django/django/test/simple.py(176)
run_tests()
-> suite.addTest(build_test(label))
/home/dan/virtual/mofin/trunk/parts/django/django/test/simple.py(90)
build_test()
-> test_module = get_tests(app_module)
/home/dan/virtual/mofin/trunk/parts/django/django/test/simple.py(16)
get_tests()
-> test_module = __import__('.'.join(app_path + [TEST_MODULE]), {},
{}, TEST_MODULE)
/home/dan/virtual/mofin/trunk/mofin/store/tests/__init__.py(3)
<module>()
-> from mofin.store.tests.test_models import TestFeed
/home/dan/virtual/mofin/trunk/mofin/store/tests/__init__.py(3)
<module>()
-> from mofin.store.tests.test_models import TestFeed
/home/dan/virtual/mofin/trunk/mofin/store/tests/test_models.py(31)
<module>()
-> from mofin.store.models import Content
> /home/dan/virtual/mofin/trunk/mofin/store/models.py(514)<module>()
-> models.signals.post_save.connect(flaggedentry_post_save,
sender=FlaggedEntry)
(Pdb)
The eagle-eyed will spot a difference there in django/test/simple.py.
The relevant code snippet is as follows:
parts = label.split('.')
if len(parts) < 2 or len(parts) > 3:
raise ValueError("Test label '%s' should be of the form
app.TestCase or app.TestCase.test_method" % label)
app_module = get_app(parts[0])
TestClass = getattr(app_module, parts[1], None)
# Couldn't find the test class in models.py; look in tests.py
if TestClass is None:
test_module = get_tests(app_module)
if test_module:
TestClass = getattr(test_module, parts[1], None)
if len(parts) == 2: # label is app.TestClass
This line:
TestClass = getattr(app_module, parts[1], None)
... causes one import of models.py in the module, then this line:
test_module = get_tests(app_module)
... causes this:
test_module = __import__('.'.join(app_path + [TEST_MODULE]), {}, {},
TEST_MODULE)
... which seems to trigger a second parse of models.py. I've checked
through our app code, and we do always seem to use the 'from
app.models import model' syntax.
It's worth mentioning that our test setup is to have a tests directory
in the app (there are a lot of tests!), and the __init__.py in that
tests directory looks something like this:
import unittest
from app.tests.test_foo import FooTestCase
def suite():
suite = unittest.TestSuite()
suite.addTest(unittest.makeSuite(FooTestCase))
return suite
... although with far more test cases.
Does the above analysis suggest the test runner is doing something
inappropriate? Or is there likely to be something else we've got wrong
in our app?
Many thanks,
Dan
--
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-us...@googlegroups.com.
To unsubscribe from this group, send email to
django-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en.
