On Mon, May 11, 2009 at 8:25 AM, timc3 <t...@timc3.com> wrote:
>
> I have just updated to trunk and now I get a problem...
OK, after looking at this a little more closely I'm not sure your shell
session is accurately re-creating whatever problem your real code is
encountering. I also see an error in your form definition that may be
causing a problem. First, let's start with the form definition:
class MediaObjectForm(forms.ModelForm):
> class Meta:
> model = MediaObject
> fields = ('path')
>
> Where MediaObject looks like this:
>
> class MediaObject(models.Model):
> name = models.CharField(max_length=256)
> path = models.FileField(_("File"), max_length=256,
> upload_to='tempUpload/')
> mob_mediaitem = models.ForeignKey(MediaItem)
> creation_date = models.DateTimeField(_("Creation date"),
> auto_now_add=True)
>
That "fields = ('path')" looks like an error. Any tuple with a single
element needs to have a trailing comma after the single element. Without
the comma your fields attribute is set to the string 'file', not a
single-element tuple containing the string 'file'. This is a common Python
gotcha.
It's a bit surprising that this error didn't cause a problem sooner. From a
few tests I tried it appears that what you show below actually worked on
Django prior to r10062. In r10062 some code was added that iterates over
the elements of fields in Meta, and then you start running into problems
because iterating over ('file') returns 'f','i','l','e', not 'file'. For a
few revisions the declaration you have there would cause an error on import,
but a fix to another bug changed things so that what you wind up with now
when you instantiate a form declared like this is a form with a fields
dictionary:
{'f': None, 'i': None, 'l': None, 'e': None}
which causes the error you see below in full_clean because none of the
'fields' have actual Field instances associated with them.
In some sense this may be considered a bug introduced into Django, as
something that worked before is now failing, but I doubt it will be fixed by
making the definition as you have it go back to working. It was a bit of a
bizarre accident that that ever worked. I think it would be more likely to
be fixed so that the error in your fields definition is more obviously
reported than it is right now. So, as a first step, I'd fix you definition
and see if things go back to working on current trunk code.
Now as to why I don't think your shell session is accurately re-creating the
real problem you are seeing in you code:
uploading files
> into a filefield so I did an interactive session in shellplus and got
> the following:
>
> In [1]: from testsite.media.forms import MediaObjectForm
>
> In [2]: d = {u'path': "my test image.png"}
>
> In [3]: f = MediaObjectForm(d)
>
You are passing a FileField in the form's data dictionary (1st positional
argument), whereas it's expected to be in the files dictionary (or 2nd
positional argument). (Further I don't think you could just specify the
file name in the files dictionary -- it needs to be an object that includes
that actual file content, see:
http://docs.djangoproject.com/en/dev/ref/forms/api/#binding-uploaded-files-to-a-form).
So the expected response to:
> In [4]: f.is_valid()
>
for a validly-defined form here would be False, as the form's required
'path' field has not been supplied to the form. Thus I don't think what
you've got in the shell session here accurately recreates your working code,
as I don't see how this could ever work. But getting it to work in the
shell is beside the point...it's possible that just fixing the fields
definition in your form will fix whatever problem your actual code is
hitting. If not, we'll need some more details on what your real code is
doing and the failure encountered in order to track down what's going on.
Karen
>
> ---------------------------------------------------------------------------
> AttributeError Traceback (most recent call
> last)
>
> /Volumes/PersonalItems/ContentCentre/development/BrokerService/code/
> brokersite/<ipython console> in <module>()
>
> /Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/site-
> packages/django/forms/forms.py in is_valid(self)
> 118 being ignored, returns False.
> 119 """
> --> 120 return self.is_bound and not bool(self.errors)
> 121
> 122 def add_prefix(self, field_name):
>
> /Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/site-
> packages/django/forms/forms.py in _get_errors(self)
> 109 "Returns an ErrorDict for the data provided for the
> form"
> 110 if self._errors is None:
> --> 111 self.full_clean()
> 112 return self._errors
> 113 errors = property(_get_errors)
>
> /Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/site-
> packages/django/forms/forms.py in full_clean(self)
> 232 # Each widget type knows how to retrieve its own
> data, because some
> 233 # widgets split data over several HTML fields.
> --> 234 value = field.widget.value_from_datadict
> (self.data, self.files, self.add_prefix(name))
> 235 try:
> 236 if isinstance(field, FileField):
>
> AttributeError: 'NoneType' object has no attribute 'widget'
>
> In [5]: f.is_valid()
> Out[5]: True
>
>
>
> As you can see the first time that I use is_valid() I get an
> AttributeError. The second time it works. MediaObjectForm looks like:
>
> Not sure why this has started happening right now.
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to
django-users+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
