On Mon, Apr 20, 2009 at 4:20 AM, Tamas Szabo <szab...@gmail.com> wrote: > As you can see the code catches and silently ignores all TypeError exceptions: > The problems with this approach are: > - Why not fail as early as possible if one of the authentication > backends configured in settings.py has a wrong signature? If nothing > else at least a warning should be logged IMHO.
Because it's conceivable that you'll be using multiple authentication systems on the same site, and that not all of them will expect the same set of credentials. The alternative -- looking at the keys in the 'credentials' dictionary and manually inspecting the argument signature of the backend's method every time -- would be cumbersome, slower and also error-prone (what happens when a backend accepts '**kwargs' but really wants a specific set of keys in there and raises a KeyError you didn't expect?) > - The bigger is that the code silently catches all TypeError > exceptions. If the signature is correct, but the custom backend > authenticator somewhere has a bug and a TypeError is raised as a > result, the exception will be hidden away. TypeError is a common > exception, so I don't think that catching and ignoring it in code that > others will write is a good idea. People who write custom auth backends should probably be unit-testing them independently of Django's auth framework, which would catch such errors early on. And since Python doesn't offer a more specific YouPassedArgumentsIDoNotLikeError, I think that means TypeError's the way to go. -- "Bureaucrat Conrad, you are technically correct -- the best kind of correct." --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to django-users+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~----------~----~----~----~------~----~------~--~---
