On Mar 10, 1:14 pm, Dmitry Teslenko <dtesle...@gmail.com> wrote:
> On Tue, Mar 10, 2009 at 16:06, Daniel Roseman
> <roseman.dan...@googlemail.com> wrote:
> > How is the view getting the task_id parameter? Your form is always
> > posting to edit/, with no parameter, so there's no way it can pass the
> > task_id to the view. Presumably your URLconf has a default to -1, and
> > there's no way to get anything else, which is why the form always
> > inserts.
> > --
> > DR.
>
> View gets proper task_id; I've added it to the edit.html template and
> get assured
> it being set right;
> Additons go from this link:
> =========================================================================== ==
> <a href="/py/test_app/edit">New task</a>
> =========================================================================== ==
>
> And editions go from this link:
> =========================================================================== ==
> <a href="/py/test_app/edit/{{ task.pk }}">Edit</a>
> =========================================================================== ==
>
> Here's excerpt from urls.py:
> =========================================================================== ==
> (r'^%stest_app/edit/$' % URL_PREFIX,
> 'test_django.test_app.views.edit' , { 'task_id' : -1 }),
> (r'^%stest_app/edit/(?P<task_id>\d+)/$' % URL_PREFIX,
> 'test_django.test_app.views.edit'),
> =========================================================================== ==
>
OK, well you'll need to post the form code then.
Also you may want to think about whether the view logic is right. I
can't see anything obvious that would cause your problem, but it's
needlessly complicated and doesn't catch all cases. For example, what
happens if the form fails validation? As far as I can see, the user is
redirected to get_test_app_url() *anyway*, which is clearly wrong -
you want to redisplay the form with the errors, instead. The Django
documentation has a good model for edit/update views, I suggest you
follow that instead.
Similarly, it's not very Pythonic to pass -1 as the default for when
there's no task. Why don't you have the view take task_id=None as a
default parameter, then you don't need to have that default in the
urls.py.
--
DR.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to
django-users+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
